This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
path: allow calling platform specific methods #5661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like |
Add path.posix and path.win32 which have the specific methods like resolve and normalize so you can specifically normalize or resolve based on the target platform.
| // This path points to another device so it is not applicable | ||
| continue; | ||
| } | ||
| var normalizeUNCRoot = function(device) { |
There was a problem hiding this comment.
function normalizeUNCRoot(device) { ?
EDIT: Oh, Trevor already pointed that out.
|
+1 Any update on this? |
|
I'm going to rebase and land before wednesday |
|
@tjfontaine Rebased your work on top of v0.12 here: https://github.com/misterdjules/node/commits/path-platform. Tests pass on OS X, Windows, Linux and SmartOS. |
|
This is now included in #8750. |
tjfontaine
added a commit
that referenced
this pull request
Nov 21, 2014
Add path.posix and path.win32 which have the specific methods like resolve and normalize so you can specifically normalize or resolve based on the target platform. PR-URL: #5661 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add path.posix and path.win32 which have the specific methods like
resolve and normalize so you can specifically normalize or resolve
based on the target platform.