Double-free of parser from FreeList in http.js

[stephank]

According to the documentation, a socket error event will be followed by a socket close event. However, the HTTP Agent frees its parser on both events, causing the same parser reference to be pushed twice to the FreeList. This causes strange behavior down the road on further requests, and even HTTP server requests are affected by it.

This patch fixed for us what's been seen in the following discussion: https://groups.google.com/d/topic/nodejs/kYnfJZeqGZ4/discussion

Possibly related issue: #784

The patch on top of v0.4 is at: https://github.com/AngryBytes/node/tree/v0.4-parser-fixes

[ry]

Fix double free of parser on error in http.Agent.

Thanks to Stéphan Kochen for the fix and Maurice Fonk for reproducing the
bug.

Closed by 66570c1.
Closed by 66570c1.