This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Change an ungraceful repetition of 'that' #9011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sentence felt clunky so rephrased the second part of the sentence to: - "if there's nothing in the write buffer, then this means nothing more will ever be provided". Instead of: - "if there's nothing in the write buffer, then that means that nothing more will ever be provided".
|
Going to close this as we're not landing in master here any more. A new PR can be opened against nodejs/node master if necessary |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentence felt clunky so rephrased the second part of the sentence to:
Instead of: