Remove assumption that CoaL external NIC is e1000g0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function get_mac | ||
| { | ||
| local mac | ||
|
|
||
| mac=$(dladm show-phys -mpo address e1000g0) | ||
| [[ $? -eq 0 ]] || fatal "failed to run dladm" | ||
| mac=$(nictagadm list | awk '/^external/{print $2}') |
There was a problem hiding this comment.
Shouldn't we be using the nictagadm parseable form here, eg. -p?
There was a problem hiding this comment.
Yes. If I'd noticed it existed I would have. Clearly I should update this. Thanks!
There was a problem hiding this comment.
Something like this?
nictagadm list -p -d ' ' | awk '/^external /{print $2}'
|
Let me know if that looks good and I'll squash and repush. |
|
Old commits were nshalman@f1a88fd and nshalman@ac3ef61 |
nshalman
added a commit
to nshalman/sdc-manta
that referenced
this pull request
May 6, 2015
|
ping! |
|
Apparently that code doesn't work... |
|
@pfmooney fixed it for me: nshalman@e7964af |
|
Merge pending @nshalman's testing. |
|
Confirmed that this worked to deploy Manta in a CoaL environment using vioif drivers (using my modified platform image). |
pfmooney
pushed a commit
that referenced
this pull request
May 19, 2015
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
|
Merged in c376881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some follow-up testing based on https://blog.shalman.org/running-sdc-coal-on-smartos/ I realized two possible issues:
This patch addresses both of those issues.
Feedback requested.