Use Nz() for string assignments from data fields

Best practice is to never assume a field will contain a string value, but use the Nz function to handle the possibility of null values. Fixes #408
joyfullservice · Jul 5, 2023 · f8d1f22 · monheimx9 · Jul 6, 2023 · f8d1f22
1 parent a19e5ca
commit f8d1f22
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/Version Control.accda.src/modules/clsDbSharedImage.cls b/Version Control.accda.src/modules/clsDbSharedImage.cls
@@ -704,12 +704,12 @@ Private Property Set IDbComponent_DbObject(ByVal RHS As Object)
     Set m_Rst = RHS
 
     ' Load in the object details.
-    m_Name = m_Rst!Name
-    m_Extension = m_Rst!Extension
+    m_Name = Nz(m_Rst!Name)
+    m_Extension = Nz(m_Rst!Extension)
     '@Ignore SetAssignmentWithIncompatibleObjectType
     Set fld2 = m_Rst!Data
     Set rst2 = fld2.Value
-    m_FileName = rst2.Fields("FileName")
+    m_FileName = Nz(rst2.Fields("FileName"))
     m_FileData = rst2.Fields("FileData")
 
     ' Clear the object references

diff --git a/Version Control.accda.src/modules/clsDbTheme.cls b/Version Control.accda.src/modules/clsDbTheme.cls
@@ -667,12 +667,12 @@ Private Property Set IDbComponent_DbObject(ByVal RHS As Object)
     Set m_Rst = RHS
 
     ' Load in the object details.
-    m_Name = m_Rst!Name
-    m_Extension = m_Rst!Extension
+    m_Name = Nz(rst!Name)
+    m_Extension = Nz(rst!Extension)
     '@Ignore SetAssignmentWithIncompatibleObjectType
     Set fld2 = m_Rst!Data
     Set rst2 = fld2.Value
-    m_FileName = rst2.Fields("FileName")
+    m_FileName = Nz(rst2.Fields("FileName"))
     m_FileData = rst2.Fields("FileData")
 
     ' Clear the object references