Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device delete crash #47

Merged
merged 14 commits into from
May 22, 2020
Merged

Fix device delete crash #47

merged 14 commits into from
May 22, 2020

Commits on May 21, 2020

  1. reformatted device/modbus.js

    joyja committed May 21, 2020
    Configuration menu
    Copy the full SHA
    3d796ec View commit details
    Browse the repository at this point in the history

  2. commented out device.config.disconnect on EthernetIP

    joyja committed May 21, 2020
    Configuration menu
    Copy the full SHA
    44f970f View commit details
    Browse the repository at this point in the history

  3. changed test to not detect destroy

    joyja committed May 21, 2020
    Configuration menu
    Copy the full SHA
    178f4b6 View commit details
    Browse the repository at this point in the history

  4. Added retry logic (similar to modbus) to ethernetip device

    joyja committed May 21, 2020
    Configuration menu
    Copy the full SHA
    69937a3 View commit details
    Browse the repository at this point in the history

  5. fixed ethernetip disconnect method

    joyja committed May 21, 2020
    Configuration menu
    Copy the full SHA
    3942ec4 View commit details
    Browse the repository at this point in the history

  6. Added EthernetIPSource.getAll() to static device.delete

    joyja committed May 21, 2020
    Configuration menu
    Copy the full SHA
    616da9b View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. added disconnect and connect devices on delete

    @joyja
    joyja committed May 22, 2020
    Configuration menu
    Copy the full SHA
    1d6117f View commit details
    Browse the repository at this point in the history

  2. fixed tests

    @joyja
    joyja committed May 22, 2020
    Configuration menu
    Copy the full SHA
    e51161f View commit details
    Browse the repository at this point in the history

  3. cleared retryInterval if device is undefined

    @joyja
    joyja committed May 22, 2020
    Configuration menu
    Copy the full SHA
    f24fc28 View commit details
    Browse the repository at this point in the history

  4. removed connected conditional on client.destroy

    @joyja
    joyja committed May 22, 2020
    Configuration menu
    Copy the full SHA
    c252898 View commit details
    Browse the repository at this point in the history

  5. added Retry Rate

    @joyja
    joyja committed May 22, 2020
    Configuration menu
    Copy the full SHA
    a139b76 View commit details
    Browse the repository at this point in the history

  6. added retry rate set & get (temporarily fixed retry rate to 5 seconds)

    @joyja
    joyja committed May 22, 2020
    Configuration menu
    Copy the full SHA
    4611ef1 View commit details
    Browse the repository at this point in the history

  7. Completely destroy client on disconnect and recreate it on connect if… 

    … it doesn't exist
    @joyja
    joyja committed May 22, 2020
    Configuration menu
    Copy the full SHA
    d5a56bd View commit details
    Browse the repository at this point in the history

  8. fixed tests to reflect client being nulled out on disconnect

    @joyja
    joyja committed May 22, 2020
    Configuration menu
    Copy the full SHA
    ad85fac View commit details
    Browse the repository at this point in the history