Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipFileExtensions #53

Merged
merged 5 commits into from Sep 7, 2018
Merged

ZipFileExtensions #53

merged 5 commits into from Sep 7, 2018

Conversation

alexleen
Copy link
Contributor

@alexleen alexleen commented Aug 17, 2018

ZipFileExtensions

Allows for use of ZipFileExtensions without accessing the Instance property.

@alexleen
Copy link
Contributor Author

@jozefizso please review and merge at your earliest convenience.

@jozefizso
Copy link
Owner

jozefizso commented Aug 20, 2018

It looks good. I'm just curious why are both .csproj files completly changed? Is it whitespace changes or something like that?

@alexleen
Copy link
Contributor Author

Yeah, if you hide whitespace changes the only thing that has been added is <Compile Include="IO\Compression\ZipFileExtensionsTests.cs" /> in SystemWrapper.Tests/SystemWrapper.Tests.csproj and <Compile Include="IO\Compression\ZipFileExtensions.cs" /> in SystemWrapper/SystemWrapper.csproj.

@jozefizso
Copy link
Owner

When I download the patch file, the .csproj files contain CRLF line endings. They should have LF in the diff.

@alexleen
Copy link
Contributor Author

Oh, good catch. Fixed.

@alexleen
Copy link
Contributor Author

Ready to merge, @jozefizso?

@jozefizso jozefizso merged commit d5172c4 into jozefizso:develop Sep 7, 2018
jozefizso added a commit that referenced this pull request Sep 7, 2018
* develop:
  Update list of authors
  Update git ignore settings
  ZipFileExtensions (#53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants