Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remaining luadata serialization to use lua_wrangler.luaify #3

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

mrstradivarius
Copy link
Contributor

There were two remaining instances of luadata.serialize: one in main.py and one in combiner.py. This commit converts these instances to use lua_wrangler.luaify, which will mean that Signpost index modules are written with the same whitespace as [[WP:SPT]].

There were two remaining instances of luadata.serialize: one in main.py
and one in combiner.py. This commit converts these instances to use
lua_wrangler.luaify, which will mean that Signpost index modules are
written with the same whitespace as [[WP:SPT]].
@jp-x-g jp-x-g merged commit a76256d into jp-x-g:main Jan 31, 2023
@jp-x-g
Copy link
Owner

jp-x-g commented Jan 31, 2023

This works fine, except for whatever this is. It seems to be introducing some strange Unicode bug which mangles a lot of characters (and gets mangled worse if you update the index with SPT afterwards).
Old version: Zambian wiki-assassins, Foundation ''über alles'', editor engagement and the innovation plateau
This version: Zambian wiki-assassins, Foundation ''\u00fcber alles'', editor engagement and the innovation plateau
SPT version: Zambian wiki-assassins, Foundation ''u00fcber alles'', editor engagement and the innovation plateau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants