Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource details to fine .dll file #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SveSop
Copy link
Contributor

@SveSop SveSop commented Jul 11, 2023

There is not really support for adding other than numbers for the version string, so using VCS_TAG seems out of the question. Used the "release" tag, but this will for now need manual update for each release.

GPU Caps Viewer still shows "unknown" for the file version of the .dll, so this is mostly just for some cosmetic "information" - similar to what DXVK does for d3d11.dll and such. "For completeness" so to speak?
nvapi_dll

There is not really support for adding other than numbers for the
version string, so using VCS_TAG seems out of the question. Used
the "release" tag, but this will for now need manual update for
each release.
@jp7677
Copy link
Owner

jp7677 commented Jul 14, 2023

Thanks for the PR. I'm actually quite torn on this one. While I don't mind the extra bits for having proper file information, maintaining versions numbers manually sounds very tedious. That said, somehow extracting the version from tags is also risky since e.g. Proton uses a very different tag format.

(on a side note, the filename should differ between 32bit and 64bit builds)

@Saancreed
Copy link
Collaborator

(on a side note, the filename should differ between 32bit and 64bit builds)

Actually, on native Windows it does not:

$ exiftool -OriginalFileName /windows/Windows/System32/nvapi64.dll 
Original File Name              : nvapi.dll

@jp7677
Copy link
Owner

jp7677 commented Jul 14, 2023

(on a side note, the filename should differ between 32bit and 64bit builds)

Actually, on native Windows it does not:

$ exiftool -OriginalFileName /windows/Windows/System32/nvapi64.dll 
Original File Name              : nvapi.dll

Thanks, well, things are never as simple as they should be :)

@SveSop
Copy link
Contributor Author

SveSop commented Jul 15, 2023

The initial thought of doing this was because i thought that GPU Caps Viewer that now shows "unknown version" for the dll would pick this up somehow, but it does not seem as it is satisfied.. If that is because of wine not really have any functions for this or whatnot i dunno, or if there is some missing setting in the "manifest" or whatever, i dunno. I can fiddle a bit with it, but it is mostly just for cosmetics i guess.

Ill keep it around on my experimental branch, and i tend to agree that it would be a bit more ideal if the version actually was some "dirty git +" tag when building, but the limitations is "4 numbers with . between them", so no letters and such there, and well.. needing manual update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants