nvapi-drs: Add NvAPI_DRS_CreateProfile

[jp7677]

Return no-implementation no prevent applications from doing more things with the profile.

This fixes a startup crash for Battle Brothers which apparently forgets to check if a function pointer is valid.

12058.183:0124:0128:info:dxvk-nvapi:NvAPI_QueryInterface NvAPI_DRS_CreateApplication: Not implemented method
12058.183:0124:0128:info:dxvk-nvapi:NvAPI_QueryInterface NvAPI_DRS_DeleteProfile: Not implemented method
12058.183:0124:0128:info:dxvk-nvapi:NvAPI_QueryInterface NvAPI_DRS_EnumApplications: Not implemented method
12058.183:0124:0128:info:dxvk-nvapi:NvAPI_QueryInterface NvAPI_DRS_GetProfileInfo: Not implemented method
12058.183:0124:0128:info:dxvk-nvapi:NvAPI_QueryInterface NvAPI_DRS_SaveSettings: Not implemented method
12058.183:0124:0128:info:dxvk-nvapi:NvAPI_QueryInterface NvAPI_DRS_SetSetting: Not implemented method
12058.183:0124:0128:info:dxvk-nvapi:NvAPI_Initialize
...
10435.820:0128:012c:info:dxvk-nvapi:<-NvAPI_Initialize: OK
10435.820:0128:012c:trace:dxvk-nvapi:NvAPI_DRS_CreateSession (ptr=0xa54a24)
10435.820:0128:012c:info:dxvk-nvapi:<-NvAPI_DRS_CreateSession: OK
10435.820:0128:012c:trace:dxvk-nvapi:NvAPI_DRS_LoadSettings (hnd=0x772955a0)
10435.820:0128:012c:info:dxvk-nvapi:<-NvAPI_DRS_LoadSettings: OK
10435.820:0128:012c:trace:dxvk-nvapi:NvAPI_DRS_FindProfileByName (hnd=0x772955a0, ptr=0xa5ea78, ptr=0xa54a20)
10435.820:0128:012c:info:dxvk-nvapi:<-NvAPI_DRS_FindProfileByName (Battle Brothers): Profile not found
10435.820:0128:012c:trace:dxvk-nvapi:NvAPI_DRS_CreateProfile (hnd=0x772955a0, ptr=0xa54a28, ptr=0xa54a20)
10435.820:0128:012c:info:dxvk-nvapi:<-NvAPI_DRS_CreateProfile: No implementation

By returning no-implementation not-supported, it doesn't call the other DRS functions. For safety we might consider to add those others as well because if it calls such a function, it explodes. I figured when playing with the return code. But from very brief testing this PR seems sufficient.

This addresses ValveSoftware/Proton#4148 (comment)

[Saancreed]

This fixes a startup crash for Battle Brothers which apparently forgets to check if a function pointer is valid.

That… should not be possible unless the game is using the open source SDK. SDK used by games has this check builtin (probably for all the functions it supports) and never even exposes to the application the fact that something like nvapi_QueryInterface even exists.

🤔

Maybe we should add a simple

static NvAPI_Status NvAPI_StubFunction(...)
{
    return NVAPI_NO_IMPLEMENTATION;
}

and return that to applications when we're asked for a function that we know about but don't have implemented?

[Saancreed]

Technically nothing wrong with this but it's not, well, scalable, we should think of something better in the long term.