Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python versions 2.7 and 3.4; add version 3.8 #43

Merged

Conversation

mfonism
Copy link
Contributor

@mfonism mfonism commented Jan 27, 2020

This PR updates the versions of Python supported by this library.

It drops versions 2.7 and 3.4 from the matrix, and adds version 3.8 .

.travis.yml Outdated
@@ -1,4 +1,4 @@
# This is required to get Travis to run Python 3.7
# This is required to get Travis to run Python 3.7 and higher versions of Python
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm this is still required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, @inglesp, it's no longer required.

https://docs.travis-ci.com/user/languages/python/

Snapshots of that page obtained from The Way back Machine show that it was rectified/solved sometime between July 13, 2019 and August 29, 2019.

I'll be glad to take that out when I get to my computer.

Thank you for the catch.

@mfonism mfonism force-pushed the 2020.01.27/update-supported-python-versions branch from c64b2ea to b1d96ae Compare January 27, 2020 18:09
@mfonism
Copy link
Contributor Author

mfonism commented Jan 27, 2020

I've updated the PR to take out the part about needing xenial to run Python 3.7 and above.

@mfonism mfonism requested a review from inglesp January 27, 2020 18:12
Copy link
Collaborator

@inglesp inglesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks sensible, thanks @mfonism!

@inglesp inglesp merged commit c68fd4b into jpadilla:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants