Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarnings: more helpful message #270

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 12, 2017

I've thought about adding stacklevel=2, but it is used internally / passed through, so that might not be that helpful.

@coveralls
Copy link

coveralls commented Jun 12, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e6dce40 on blueyed:better-DeprecationWarning into 6f19288 on jpadilla:master.

@jpadilla
Copy link
Owner

@blueyed good stuff, thanks!

@jpadilla jpadilla merged commit 639fa01 into jpadilla:master Jun 12, 2017
@blueyed blueyed deleted the better-DeprecationWarning branch June 12, 2017 14:51
blueyed added a commit to blueyed/pyjwt that referenced this pull request Jun 12, 2017
Followup to jpadilla#270:

It seems that "verify" is only deprecated with `PyJWS.decode`, which
makes sense, since you would have to override a lot of options to skip
the verification in `PyJWT._validate_claims`.

This makes `PyJWT.decode` use the `verify_signature` option when calling
`PyJWT.decode`, and therefore also allows to use `stacklevel=2` there
then for the DeprecationWarning.
blueyed added a commit to blueyed/pyjwt that referenced this pull request Jun 12, 2017
Followup to jpadilla#270:

It seems that "verify" is only deprecated with `PyJWS.decode`, which
makes sense, since you would have to override a lot of options to skip
the verification in `PyJWT._validate_claims`.

This makes `PyJWT.decode` use the `verify_signature` option when calling
`PyJWT.decode`, and therefore also allows to use `stacklevel=2` there
then for the DeprecationWarning.
blueyed added a commit to blueyed/pyjwt that referenced this pull request Jun 21, 2017
Followup to jpadilla#270:

It seems that "verify" is only deprecated with `PyJWS.decode`, which
makes sense, since you would have to override a lot of options to skip
the verification in `PyJWT._validate_claims`.

This makes `PyJWT.decode` use the `verify_signature` option when calling
`PyJWT.decode`, and therefore also allows to use `stacklevel=2` there
then for the DeprecationWarning.
jpadilla pushed a commit that referenced this pull request Jun 21, 2017
Followup to #270:

It seems that "verify" is only deprecated with `PyJWS.decode`, which
makes sense, since you would have to override a lot of options to skip
the verification in `PyJWT._validate_claims`.

This makes `PyJWT.decode` use the `verify_signature` option when calling
`PyJWT.decode`, and therefore also allows to use `stacklevel=2` there
then for the DeprecationWarning.
rylanhall33 added a commit to rylanhall33/pyjwt that referenced this pull request Jun 15, 2022
Followup to jpadilla/pyjwt#270:

It seems that "verify" is only deprecated with `PyJWS.decode`, which
makes sense, since you would have to override a lot of options to skip
the verification in `PyJWT._validate_claims`.

This makes `PyJWT.decode` use the `verify_signature` option when calling
`PyJWT.decode`, and therefore also allows to use `stacklevel=2` there
then for the DeprecationWarning.
xmas7 pushed a commit to RubyOnWorld/pyjwt that referenced this pull request Sep 6, 2022
Followup to jpadilla/pyjwt#270:

It seems that "verify" is only deprecated with `PyJWS.decode`, which
makes sense, since you would have to override a lot of options to skip
the verification in `PyJWT._validate_claims`.

This makes `PyJWT.decode` use the `verify_signature` option when calling
`PyJWT.decode`, and therefore also allows to use `stacklevel=2` there
then for the DeprecationWarning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants