Warn about missing algorithms arg only when verify is True #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might not hurt to add a test for this. |
suligap
force-pushed
the
no-alg-deprecate-warn-only-when-verify-is-true
branch
from
9e63858
to
4b16fe8
Compare
|
@mark-adams thanks. Tests added (and the original change fixed). |
|
@suligap Sorry for the delay in reviewing. This looks good. Would you mind adding an entry to the CHANGELOG mentioning the behavior that this fixes? |
mark-adams
approved these changes
Aug 26, 2017
mark-adams
suggested changes
Aug 26, 2017
suligap
force-pushed
the
no-alg-deprecate-warn-only-when-verify-is-true
branch
2 times, most recently
from
cabc3ee
to
0fa05a6
Compare
|
@mark-adams thanks. CHANGELOG updated! |
jpadilla
reviewed
Aug 28, 2017
| - Remove uses of deprecated functions from the cryptography package. | ||
| - Warn about missing `algorithms` param to `decode()` only when `verify` param is `True` [#281][281] |
There was a problem hiding this comment.
This is missing defining the link for 281 at the bottom of the file.
There was a problem hiding this comment.
Thanks @jpadilla! That's fixed now.
Since no signature verification will occur, passing in `algorithms` does not make much sense.
suligap
force-pushed
the
no-alg-deprecate-warn-only-when-verify-is-true
branch
from
0fa05a6
to
1b57ab2
Compare
jpadilla
approved these changes
Aug 31, 2017
mark-adams
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since no signature verification will occur, passing in
algorithmsdoesnot make much sense.