Require cryptography >= 1.4, replace deprecated functions #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good but it needs to be added to the CHANGELOG before it can be merged. |
The signer/verifier interfaces are deprecated in cryptography==2.0. The alternative sign/verify interfaces were added in cryptography==1.4.
bluetech
force-pushed
the
replace-cryptography-deprecated-again
branch
from
2b51474
to
ed27376
Compare
|
@mark-adams I added CHANGELOG entries. |
mark-adams
approved these changes
Aug 25, 2017
|
@bluetech Thanks for the contribution! |
bamarni
added a commit
to dcos/dcos-core-cli
that referenced
this pull request
Aug 3, 2018
It started to trigger a warning after the cryptography bump. cf. jpadilla/pyjwt#285 https://jira.mesosphere.com/browse/DCOS-40139
bamarni
added a commit
to dcos/dcos-core-cli
that referenced
this pull request
Aug 3, 2018
It started to trigger a warning after the cryptography bump. cf. jpadilla/pyjwt#285 https://jira.mesosphere.com/browse/DCOS-40139
bamarni
added a commit
to dcos/dcos-core-cli
that referenced
this pull request
Aug 16, 2018
It started to trigger a warning after the cryptography bump. cf. jpadilla/pyjwt#285 https://jira.mesosphere.com/browse/DCOS-40139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signer/verifier interfaces are deprecated in cryptography==2.0. The
alternative sign/verify interfaces were added in cryptography==1.4.