Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a way to use custom time source for time validation (issue #364) #365

Closed
wants to merge 2 commits into from

Conversation

thekondor
Copy link

decode() is extended with an option to use custom UTC current time value to solve #364. Tests are provided.

I decided to use an approach to specify a custom UTC current time's value through using options argument; since it looks more organic for the current implementation. Another possible approach could be is passing utcnow() function through a setter function like register_algorithm().

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 76.87%

Totals Coverage Status
Change from base Build 15: 0.2%
Covered Lines: 555
Relevant Lines: 722

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 76.87%

Totals Coverage Status
Change from base Build 15: 0.2%
Covered Lines: 555
Relevant Lines: 722

💛 - Coveralls

@github-actions github-actions bot added the stale Issues without activity for more than 60 days label Jun 19, 2022
@github-actions github-actions bot closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues without activity for more than 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants