Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EdDSA to docs #531

Merged
merged 1 commit into from
Nov 13, 2020
Merged

add EdDSA to docs #531

merged 1 commit into from
Nov 13, 2020

Conversation

wasdee
Copy link
Contributor

@wasdee wasdee commented Nov 13, 2020

Since the implementation is merged. #455 docs too should update. So, none need to search PRs, Issues, Source Code

@auvipy auvipy merged commit e25b263 into jpadilla:master Nov 13, 2020
@wasdee wasdee deleted the patch-1 branch November 13, 2020 04:33
@twosigmajab
Copy link

Great this is now documented! I suggest also sending a PR to https://github.com/jsonwebtoken/jsonwebtoken.github.io, the repo that backs https://jwt.io, since it's been listing a big question mark next to EdDSA support for pyjwt, and a lot of users probably chose a different library within the last year as a result, even though pyjwt has had support all this time.

wasdee added a commit to wasdee/jsonwebtoken.github.io that referenced this pull request Nov 14, 2020
jpadilla/pyjwt#455 jpadilla/pyjwt#531 these are some proved about the support of pyjwt eddsa.
@wasdee
Copy link
Contributor Author

wasdee commented Nov 14, 2020

Great this is now documented! I suggest also sending a PR to https://github.com/jsonwebtoken/jsonwebtoken.github.io, the repo that backs https://jwt.io, since it's been listing a big question mark next to EdDSA support for pyjwt, and a lot of users probably chose a different library within the last year as a result, even though pyjwt has had support all this time.

PR-ed jsonwebtoken/jsonwebtoken.github.io#499

@jpadilla jpadilla added this to the v2.0.0 milestone Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants