Refactor jwt/jwks_client.py without requests dependency #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows dropping a dependency that isn't very necessary. The requests library was used for a single line of code. This same code is just as easily expressible using the stdlib, thus alllows removing a dependency. Tests were adjusted to mock this new approach.
jpadilla
reviewed
Dec 17, 2020
| r = requests.get(self.uri) | ||
| return r.json() | ||
| with urllib.request.urlopen(self.uri) as response: | ||
| return json.load(response) |
There was a problem hiding this comment.
🙈 heh this was so much easier than all the cruft I had added.
jpadilla
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows dropping a dependency that isn't very necessary.
The requests library was used for a single line of code. This same code
is just as easily expressible using the stdlib, thus alllows removing a
dependency.
Tests were adjusted to mock this new approach.