Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use implicit optionals #705

Merged
merged 3 commits into from Oct 22, 2021
Merged

Don't use implicit optionals #705

merged 3 commits into from Oct 22, 2021

Commits on Oct 22, 2021

  1. Turn off implicit-optional

    @rekyungmin
    rekyungmin committed Oct 22, 2021
    Copy the full SHA
    0b84cff View commit details
    Browse the repository at this point in the history

  2. Change type annotations to use explicit optional 

    According to PEP 484, implicit Optional is no longer recommended.
    @rekyungmin
    rekyungmin committed Oct 22, 2021
    Copy the full SHA
    113ff3f View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 22, 2021
    Copy the full SHA
    ba0d522 View commit details
    Browse the repository at this point in the history