Update life360_app.groovy #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many updates, cleanups
|
Hi @imnotbob - you're the expert so I'm sure these are all good changes. To that end, are you using an IDE to help with code completion? I noticed the lines below which looks like something I'd see from IntelliJ or another JetBrains IDE anyway - I'll test this out locally and if it works I'll merge it in and update HPM thanks, |
|
Yes, I use intellij |
jpage4500
reviewed
Sep 7, 2023
| // TODO: experiment with these values.. make sure we're not calling the API too frequently but still get timely user updates | ||
| if (numLocationUpdates == 0) { | ||
| // update every 300 (was 30,15,10) seconds | ||
| refreshSecs = 300 |
There was a problem hiding this comment.
whoa.. this isn't good. We should never be updating members more frequently than 1 minute and when active every 10 seconds is what I wrote.
I didn't see this originally but now I need to take control of this again until I have more time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many updates, cleanups
Happy to discuss