Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not make SlimeSend public? #29

Closed
moll opened this issue Nov 14, 2012 · 6 comments
Closed

Why not make SlimeSend public? #29

moll opened this issue Nov 14, 2012 · 6 comments

Comments

@moll
Copy link

moll commented Nov 14, 2012

Hey,

I'm trying to use Slime to start a process straight from Vim, and for that it'd be really handy to just send a command line down to Screen. I see there's the SlimeSend function which is exactly what I'm after, but it's private. Why not make it public?

@jpalardy
Copy link
Owner

I think I didn't expose the function because I didn't think it was useful.

If you patch it, test it, and send a pull request — I'll accept it :-)

@moll
Copy link
Author

moll commented Nov 18, 2012

I assume by testing you mean manual, because there are no existing unit tests for vim-slime? :P
But I'll give it a spin hopefully in the near future.

There is an existing command titled SlimeSend which actually calls SlimeSendRange or something. I'm wondering how to handle that naming conflict — SlimeSend would make more sense to be the name of the command that you can give a string argument to.

@jpalardy
Copy link
Owner

Consider SlimeSend to be the public interface, while SlimeSendRange is a helper.

@jpalardy jpalardy closed this as completed Feb 1, 2013
@moll
Copy link
Author

moll commented Feb 1, 2013

^ Closing makes sense for now. I'll ping back when I get around to working on this! ;)

@jpalardy
Copy link
Owner

jpalardy commented Feb 1, 2013

Sure thing.

@moll
Copy link
Author

moll commented Jul 4, 2013

I'm guessing #36 did that work already. Yay for others doing the work. 8-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants