Use absolute path to tmux socket #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,26 +44,34 @@ endfunction | |||
| " Tmux | |||
| """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" | |||
|
|
|||
| function! s:TmuxSocket() | |||
| " The socket path is the first value in the comma-separated list of $TMUX. | |||
| return split($TMUX, ',')[0] | |||
There was a problem hiding this comment.
The presence of the TMUX environment variable assumes that we are running VIM inside TMUX. That's not necessarily the case…
There was a problem hiding this comment.
If they're configuring slime for use with tmux, I would presume it is, right? In the call graph, this is only ever called from TmuxConfig.
There was a problem hiding this comment.
The destination terminal needs to run TMUX. The "source" terminal, where VIM runs, doesn't. In practice, I've used vim-slime in both configurations.
However the configuration can be obtained, I don't think it's a good idea to assume the (TMUX) variable exists.
Pull default from `$TMUX` in environment. Closes jpalardy#99
|
Closing this -- not useful for everybody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull default from
$TMUXin environment.Closes #99
I also changed the default pane to
:.2instead of the current pane. If that isn't acceptable, then I think it makes sense to split the config into independent variables instead of packaging them in a struct, so that their defaults can be overridden individually.