Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color inconsistent on mobile when dark mode enabled #796

Closed
nanowatts opened this issue Jan 27, 2024 · 2 comments · Fixed by #848
Closed

Background color inconsistent on mobile when dark mode enabled #796

nanowatts opened this issue Jan 27, 2024 · 2 comments · Fixed by #848
Labels
bug Something isn't working

Comments

@nanowatts
Copy link

nanowatts commented Jan 27, 2024

Issue description

Dark mode on mobile has a jarring break in background color. Verified in my personal usage of Congo and in the official theme documentation. I have not been able to reproduce in any desktop browser and only see this issue in iOS Safari.
IMG_3009
IMG_3010

Theme version

2.4.2

Hugo version

hugo v0.108.0+extended darwin/arm64

Which browser rendering engines are you seeing the problem on?

WebKit (Safari)

URL to sample repository or website

nanowatts.net

Hugo output or build error messages

No response

@nanowatts nanowatts added the bug Something isn't working label Jan 27, 2024
@wolfspyre
Copy link
Contributor

Does this problem still manifest with current theme version and current hugo?
(current hugo: 0.122) (current congo 2.8.0)

(quite a few things that were impactful have changed since... so.... it's worth checking imo)

@pomeloy
Copy link
Contributor

pomeloy commented Jan 30, 2024

Does this problem still manifest with current theme version and current hugo? (current hugo: 0.122) (current congo 2.8.0)

Yes.

For a quick and dirty solution add this to assets/js/appearance.js:

window.addEventListener("load", function(){
  setThemeColor();
});

ItsSunnyMonster added a commit to ItsSunnyMonster/congo that referenced this issue Apr 1, 2024
Fixes jpanther#796 by setting the theme color when the DOM loads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants