-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explanation of units in Tensormol 0.1 publication... #25
Comments
Hi Justin,
If you go to line 4881, 4891 and 4893 in TFNetworks/TFMolInstanceDirect.py,
you can see "natom" in those lines. The "natom" is actually the 1/(number
of atoms in each molecule) as you can see from line 1902 or line 1936 in
Containers/TensorMolData.py
As you can see from the code, the denominator is inside the squared part.
Sorry for the confusion caused by the naming.
…-Best,
Kun
On Fri, Mar 9, 2018 at 2:54 PM, Justin Smith ***@***.***> wrote:
We've noticed a few issues with units on errors in the Tensormol paper,
which is making it hard to compare results. Can you provide (or point to
them in the code) the equations used to compute the energy, force, and
dipole errors? Our primary confusion is where the per atom part of the
equation comes in. From your cost function it appears to be inside the
squared part. Is this true from the reported errors? Thanks so much!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#25>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHG2WBKlfqcjNCPd8DYURrNWMP3QcU_Sks5tct3egaJpZM4SkyKY>
.
|
Justin-
We're just simple men of simple pleasures, and quite certain the ANI networks are more throughly trained, on more data and welcome any reports that your charges/dipoles are more accurate. I would add that our published networks are under-trained simply because we just didn't even feel like waiting longer. The longer this field can avoid becoming a pissing match the better... Best- |
I need to chime into this one... I think the forces are actually in J mol-1 A-1. |
We've noticed a few issues with units on errors in the Tensormol paper, which is making it hard to compare results. Can you provide (or point to them in the code) the equations used to compute the energy, force, and dipole errors? Our primary confusion is where the per atom part of the equation comes in. From your cost function it appears to be inside the squared part. Is this true from the reported errors? Thanks so much!
The text was updated successfully, but these errors were encountered: