Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation of units in Tensormol 0.1 publication... #25

Closed
Jussmith01 opened this issue Mar 9, 2018 · 3 comments
Closed

Explanation of units in Tensormol 0.1 publication... #25

Jussmith01 opened this issue Mar 9, 2018 · 3 comments

Comments

@Jussmith01
Copy link

We've noticed a few issues with units on errors in the Tensormol paper, which is making it hard to compare results. Can you provide (or point to them in the code) the equations used to compute the energy, force, and dipole errors? Our primary confusion is where the per atom part of the equation comes in. From your cost function it appears to be inside the squared part. Is this true from the reported errors? Thanks so much!

@kunkinger
Copy link
Collaborator

kunkinger commented Mar 9, 2018 via email

@jparkhill
Copy link
Owner

Justin-
Hope all's well down there. Units are def awk af although I wouldn't call it an issue.

  • Energies are Hartree.
  • Forces are in Joules/Angstrom, converted from Hartree/Ang in TFMolManage after the instance.evaluate.
  • Dipoles come out in atomic units, but were converted to the Debye reported in the paper (not within the package -- I just had Kun Check)

We're just simple men of simple pleasures, and quite certain the ANI networks are more throughly trained, on more data and welcome any reports that your charges/dipoles are more accurate. I would add that our published networks are under-trained simply because we just didn't even feel like waiting longer. The longer this field can avoid becoming a pissing match the better...

Best-
John

@Dom1L
Copy link

Dom1L commented Mar 19, 2018

I need to chime into this one...

I think the forces are actually in J mol-1 A-1.
The conversion factor JOULEPERHARTREE that is defined in TensorMol/PhysicalData.py is the conversion factor from Hartree to J/mol and not Hartree to Joule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants