Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking GNN #10

Closed
wants to merge 6 commits into from
Closed

Benchmarking GNN #10

wants to merge 6 commits into from

Conversation

jmduarte
Copy link
Contributor

@jmduarte jmduarte commented Nov 28, 2019

PR including:

  • Updated "EdgeNet" model and graph data class to include distance as an "edge feature"
  • Added GNN to clustering benchmarking code and plotting notebook
  • Currently using an arbitrary threshold of 0.9, but performance seems promising (there seems to also be two populations --- one where clustering "fails" and returns much of the initial graph and another where clustering succeeds)

max_block_size_TTbar-Run3
num_blocks_TTbar-Run3
edge_precision_recall_TTbar-Run3

@jmduarte jmduarte changed the title WIP: Benchmarking GNN Benchmarking GNN Dec 5, 2019
@jpata
Copy link
Owner

jpata commented Jan 30, 2020

@jmduarte, I merged these changes in #12, therefore I'll close this PR. The edge classifier GNN works, I'm able to reproduce the results that you get. I'll report the end-to-end training results in the PF group meeting, but we can keep these studies with the factorized models in mind.

@jpata jpata closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants