Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project dead? #1088

Closed
naturefund-falk opened this issue Jun 9, 2022 · 7 comments
Closed

Is this project dead? #1088

naturefund-falk opened this issue Jun 9, 2022 · 7 comments

Comments

@naturefund-falk
Copy link

At least the data directory is not updated since 2 years. But also on the website some new mayor airports are missing. So whats the status of the project.

@reedy
Copy link
Collaborator

reedy commented Sep 25, 2022

Would also be curious too... #1085 and #1083 make it somewhat hard to even attempt to hack on this codebase

@jpatokal
Copy link
Owner

jpatokal commented Oct 15, 2022

'e's not dead but 'e's definitely pining for the fjords. The airport and airline databases are so badly out of date that this requires a thorough cleanup, not just point fixes, and merging existing data with new data without breaking everybody's flights in the process has proven to be very complicated -- and I want to make this a clean process going forward, so the data can be updated going forward as well. Realistically I don't expect to be able to finish this before 2023.

@reedy
Copy link
Collaborator

reedy commented Oct 18, 2022

What's the best way to make/contribute patches that are likely to be merged?

It'd be great to do some automated cleanup of code style... Fixing things like leading whitespace, consistent use of {} around conditionals (see openssl for the issues not using them can cause), and other cleanup of some legacy code and practices... For example most of the trailing ?> are not needed, and generally are actively advised against being done...

@jpatokal
Copy link
Owner

I'm happy to review any reasonable-looking pull requests.

@chrisrosset
Copy link
Collaborator

I would be interested in helping out with code improvement efforts. I've managed to get the site running locally because I think I'm affected by #1101 (not much progress there just yet).

Are there specific small things worth looking at? Cleaning up errors, upgrading to PHP8, or something else entirely?

@reedy, I see you've been sending lots of PRs lately. Are you working towards something specific?

@reedy
Copy link
Collaborator

reedy commented Jan 10, 2023

@reedy, I see you've been sending lots of PRs lately. Are you working towards something specific?

Not really; fixing a mixture of bugs (that affect me, at least) and trying to improve things generally.

Some of the PR are fixing deprecated related logspam, in which some cases will be more an issue in PHP 8.0/8.1/8.2 with things becoming more strict.

@reedy
Copy link
Collaborator

reedy commented Jan 10, 2023

It's a question for @jpatokal I guess... Whether there's a chance of more people getting rights to merge code, and to some extent deploy it...

@reedy reedy closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants