Merge pull request #6 from DevFactory/release/utility-classes-should-…

…not-have-public-constructors-fix-1 squid:S1118 - Utility classes should not have public constructors
jpaulynice · Mar 7, 2016 · 490ed60 · 490ed60
2 parents ce0130f + 0d11c03
commit 490ed60
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 5 deletions.
diff --git a/app/src/main/java/com/jigdraw/draw/util/Base64Util.java b/app/src/main/java/com/jigdraw/draw/util/Base64Util.java
@@ -28,7 +28,10 @@
  *
  * @author Jay Paulynice
  */
-public class Base64Util {
+public final class Base64Util {
+
+    private Base64Util() {}
+
     /**
      * Convert bitmap to base 64 string
      *

diff --git a/app/src/main/java/com/jigdraw/draw/util/DBUtil.java b/app/src/main/java/com/jigdraw/draw/util/DBUtil.java
@@ -21,7 +21,10 @@
  *
  * @author Jay Paulynice
  */
-public class DBUtil {
+public final class DBUtil {
+
+    private DBUtil() {}
+
     public static final int DATABASE_VERSION = 1;
     public static final String DATABASE_NAME = "jigsaw.db";
     public static final String JIGSAW_TABLE = "jigsaw_images";

diff --git a/app/src/main/java/com/jigdraw/draw/util/EntityUtil.java b/app/src/main/java/com/jigdraw/draw/util/EntityUtil.java
@@ -32,7 +32,9 @@
  *
  * @author Jay Paulynice
  */
-public class EntityUtil {
+public final class EntityUtil {
+
+    private EntityUtil() {}
 
     /**
      * Convert the given image entity to content values

diff --git a/app/src/main/java/com/jigdraw/draw/util/GridUtil.java b/app/src/main/java/com/jigdraw/draw/util/GridUtil.java
@@ -18,7 +18,10 @@
 
 import android.view.View;
 
-public class GridUtil {
+public final class GridUtil {
+
+    private GridUtil() {}
+
     public static float getViewX(View view) {
         return Math.abs((view.getRight() - view.getLeft()) / 2);
     }

diff --git a/app/src/main/java/com/jigdraw/draw/util/ToastUtil.java b/app/src/main/java/com/jigdraw/draw/util/ToastUtil.java
@@ -24,7 +24,10 @@
  *
  * @author Jay Paulynice
  */
-public class ToastUtil {
+public final class ToastUtil {
+
+    private ToastUtil() {}
+
     /**
      * Create short toast and show message
      *