Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on Visual Studio 2015, works on 2017+ #21

Closed
akien-mga opened this issue Jul 1, 2019 · 4 comments
Closed

Build fails on Visual Studio 2015, works on 2017+ #21

akien-mga opened this issue Jul 1, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@akien-mga
Copy link

See godotengine/godot#30129 and build log on AppVeyor CI using Visual Studio 2015: https://ci.appveyor.com/project/akien-mga/godot/builds/25592281

Apparently the library builds fine against VS 2017. CC @fire.

Given Godot's big userbase we try to support VS 2015 as min version, even though 2017 or later is recommended (or even MinGW with latest GCC and LTO for best performance). So if xatlas can be made to build against VS 2015 without too much hassle, that would be great for our use case :)

@jpcy jpcy added the enhancement New feature or request label Jul 1, 2019
@jpcy
Copy link
Owner

jpcy commented Jul 1, 2019

I'll fix this and setup CI so the build doesn't break in the future.

jpcy added a commit that referenced this issue Jul 1, 2019
@jpcy
Copy link
Owner

jpcy commented Jul 1, 2019

Fixed

@jpcy jpcy closed this as completed Jul 1, 2019
@akien-mga
Copy link
Author

Thanks!

@fire
Copy link

fire commented Jul 1, 2019

Thanks for following up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants