Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array<T> broke build #7

Closed
hugoam opened this issue Nov 6, 2018 · 2 comments
Closed

Array<T> broke build #7

hugoam opened this issue Nov 6, 2018 · 2 comments

Comments

@hugoam
Copy link

hugoam commented Nov 6, 2018

The commit that introduced Array<T> (fb20efd) broke the build for compilers that strictly parse templates (gcc, clang...).
The find and replaceWithLast functions use undefined functions nv::find and nv::swap.
The latter can just be replaced with std::swap, and the first, I don't know. These Array functions are dead code anyway so they could be removed altogether.

jpcy added a commit that referenced this issue Nov 7, 2018
@jpcy
Copy link
Owner

jpcy commented Nov 7, 2018

Thanks. I need to setup CI so I actually notice when things break.

@jpcy jpcy closed this as completed Nov 7, 2018
@hugoam
Copy link
Author

hugoam commented Nov 7, 2018

Thanks ! Yeah, thanks for adding CI too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants