-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge: Does Not Export Very Dirty Artboard #5
Comments
Seems like Edge may have a limit of 2048 characters 😢. Other browsers allow URLs much larger. Stack Overflow: |
So, to be clear, this means that art-boards like the problematic URL mentioned above where every cell is filled do not export successfully in Edge because the URL seems to exceed its limits. AFAIK the spec doesn't enforce a limit. Different browsers have their own limitations. |
According to this Stack Overflow the URL limit is 81578 character. Our API should never get anywhere near that. 4000 seems to be it. |
Opened this URL in the Edge bug tracker I know this means that technically part of the app doesn't work in Edge 😢 (really big art–boards don't export) but I'd make the case that this is a browser issue. I think this web app has pushed some boundaries also ran into #1 which was discovered why the |
It's kind of ironic if you go to In Edge and try and export it won't work because of the amount of characters. Safari, Chrome, Firefox work fine. Works in Safari iOS. I believe these browsers support such large URLs they'd scale up to larger favicons sizes but Edge can't seem to handle the 16x16 at this time. Testing expanded URL: |
Azure doesn't like big URLs either. Notice that in the Heroku environment in any browser other than Edge this big fat URLs work just fine:
But Azure won't serve these URLs to any browser:
Update: |
I've confirmed with Azure support that they have a limit of 2048 character URLs. Haven't confirmed with Edge yet but it seems to be the same. |
I've found the Edge tracking issue https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8819146/ It is assigned to someone and notes that
and
which goes for my application as well. So there's hope for makeanico in Edge yet 🙏 . |
One hack to possibly work around Edge's URL size limitation would be to check the Referrer Header, assuming Edge sends the whole thing. I'm not sure if the presence of the header can be relied on enough. |
Sounds like this will be fixed soon!!! 🎉
|
Ok maybe not as soon as we hoped, but it is being tracked. And Edge moves quick these days.
|
I tried this
Still doesn't work because I think Edge doesn't send the entire URL in the Header. Could send the dataURI over XHR but that still doesn't fix no-js support. |
Any news about a possible solution? I'm having the same problem with urls in edge 😞 |
the
<a download>
pattern is used to easily export the graphics by sending the URL params to the API. At a certain point, I'm not sure the exact threshold, Microsoft Edge basically breaks. It doesn't handle the download link correctly and it will only allow you to try and save the file as text.This feels like an Edge bug to me. The URLs can get large, but all the other browsers handle it fine.
Example of a 4039 character problematic URL in Edge 38.14393
Notice the problematic URL is just the non–problematic URL with more parameter data.
The text was updated successfully, but these errors were encountered: