Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Arguments values starting with non-word chars #55

Conversation

montgomerybc
Copy link
Contributor

Updated regex to allow for non-word starting characters

@jpdillingham
Copy link
Owner

Closes #54

@jpdillingham
Copy link
Owner

Thanks for this, I agree it is a necessary change. When testing I uncovered a semi-related bug with paths starting with / instead of \; there's an explicit part of the regex that allows this with \\/? prior to the previous \w and it causes issues parsing something like /a /b /c into 3 bools, so I'll need to follow up with a PR to remove that.

I'm bringing this up because this is a breaking change and a reversal of slash support in values; previously --foo /bar.txt was supported and --foo \bar.txt was not; now the inverse will be true. Any values starting with a forward slash will need to be quoted.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants