Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow changing font family #92

Merged

Conversation

benomatis
Copy link
Contributor

Closes #90

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2021

🦋 Changeset detected

Latest commit: 4559201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocketseat/gatsby-theme-docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpedroschmitz
Copy link
Owner

Could you add docs for this @benomatis?

@benomatis
Copy link
Contributor Author

@jpedroschmitz Assuming you meant a changeset, would you think of this as a minor change? Referring to the bump type I should choose.

@jpedroschmitz
Copy link
Owner

A changeset would also be needed, but it looks great.

I mean just adding a note on our docs page about changing the font family - Link. This way, if other users want to change it, they know how to do so. Maybe also adding an alert about how you can include a custom font on Gatsby.

@benomatis
Copy link
Contributor Author

@jpedroschmitz Sure, no problem, I just added it - hope it's ok.

Copy link
Owner

@jpedroschmitz jpedroschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @benomatis ❤️

@jpedroschmitz jpedroschmitz changed the title feat: Allow change font family feat: allow changing font family Aug 28, 2021
@jpedroschmitz jpedroschmitz merged commit fa2cc45 into jpedroschmitz:main Aug 28, 2021
@github-actions github-actions bot mentioned this pull request Aug 28, 2021
@benomatis benomatis deleted the feat/allow-change-font-family branch March 29, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to change font family?
2 participants