Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<label for='id'> should be replaced #87

Closed
X-Ryl669 opened this issue Jul 13, 2019 · 0 comments · Fixed by #90
Closed

<label for='id'> should be replaced #87

X-Ryl669 opened this issue Jul 13, 2019 · 0 comments · Fixed by #90
Labels
bug

Comments

@X-Ryl669
Copy link
Contributor

X-Ryl669 commented Jul 13, 2019 •
edited

Currently, if you have a <label> element, the for attribute expect an id. Since ids are renamed, so should be the for attribute.

I'm trying to correct this and submit a PR.
@X-Ryl669 X-Ryl669 changed the title <label for='id> should be replaced <label for='id'> should be replaced Jul 15, 2019
X-Ryl669 added a commit to X-Ryl669/node-rcs-core that referenced this issue Jul 15, 2019
@X-Ryl669
Add support for replacing label's "for" attribute
6a551d4 
Fix JPeer264#87
X-Ryl669 added a commit to X-Ryl669/node-rcs-core that referenced this issue Jul 15, 2019
@X-Ryl669
Add support for replacing label's "for" attribute
46de26a 
Fix JPeer264#87
@X-Ryl669 X-Ryl669 mentioned this issue Jul 15, 2019
Merged
X-Ryl669 added a commit to X-Ryl669/node-rcs-core that referenced this issue Jul 15, 2019
@X-Ryl669
Add support for replacing label's "for" attribute
a338c8f 
Fix JPeer264#87
@JPeer264 JPeer264 added the bug label Jul 23, 2019
X-Ryl669 added a commit to X-Ryl669/node-rcs-core that referenced this issue Aug 4, 2019
@X-Ryl669
Add support for replacing label's "for" attribute
9ec03f6 
Fix JPeer264#87
JPeer264 added a commit that referenced this issue Aug 4, 2019
@X-Ryl669 @JPeer264
Fix label for attribute (#90)
55ff974 
Fix #87

Co-authored-by: Jan Peer Stöcklmair <jan.oster94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix label for attribute X-Ryl669/node-rcs-core
2 participants
@X-Ryl669 @JPeer264