Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with the Styled Chat #9

Closed
nikijaz opened this issue Jun 20, 2022 · 5 comments
Closed

Incompatible with the Styled Chat #9

nikijaz opened this issue Jun 20, 2022 · 5 comments

Comments

@nikijaz
Copy link

nikijaz commented Jun 20, 2022

Styled Chat
Logs: https://mclo.gs/Is8bvrE
@nikijaz
Copy link
Author

nikijaz commented Jun 20, 2022

Styled Chat: v1.3.2
Better Fabric Console: v1.0.5

@nikijaz
Copy link
Author

nikijaz commented Jun 20, 2022 •
edited

Patbox/StyledChat#24

@nikijaz
Copy link
Author

nikijaz commented Jun 20, 2022

My conclusion is that the problem is in this commit.

@jpenilla
Copy link
Owner

No idea what's happening here, that commit doesn't touch anything relevant and if it's actually the cause it's probably a fabric bug of some sort. I don't touch registries at all, let alone the chat type registry. My only guess was maybe this https://github.com/jpenilla/better-fabric-console/blob/master/src/main/java/xyz/jpenilla/betterfabricconsole/BetterFabricConsole.java#L86 is loading the registry class too early, but removing it didn't make any difference in my testing.

@nikijaz
Copy link
Author

nikijaz commented Jun 23, 2022

The problem is not with the Better fabric Console

@nikijaz nikijaz closed this as completed Jun 23, 2022
@jpenilla jpenilla mentioned this issue Jul 2, 2022
Closed
jpenilla added a commit to jpenilla/mods-command that referenced this issue Jul 2, 2022
@jpenilla
Remove confabricate
26b91a2 
see jpenilla/better-fabric-console#9 and jpenilla/better-fabric-console#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpenilla @nikijaz