Yet another Ecommerce Bridge Sync Error endpoint #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream changes
Upstream changes
Also updated the other sync error methods to check for the correct auth type
Neuer Bridge-Error-Endpunkt
|
Thanks for the explanation and fixes! That's quite annoying from HubSpot. I'll review/merge and hopefully get a release out soon! |
|
This is now live on pip as version Thanks again for your contributions! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly introduces a method to use yet another endpoint to query sync errors of the Ecommerce Bridge API. I found that the other two endpoints that generally serve a similar purpose cannot be used in conjunction with OAuth (even though the docs did mention it at the time), which I reported to HubSpot. A few weeks later, the docs suddenly list a third endpoint that can only be used with OAuth tokens.
So now there 3 endpoints and they all only work with different kinds of authentication. 🤷♂️ This is why I also added checks for the used auth type to the client whenever one of these methods is called. Hopefully this will help others to avoid the pain I went through to figure this out.