Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base.py #85

Closed
wants to merge 1 commit into from
Closed

base.py #85

wants to merge 1 commit into from

Conversation

MutelS
Copy link

@MutelS MutelS commented Jan 17, 2020

fixed url formation with the addition of properties.

@MutelS
base.py
bc2b891 
fixed url formation with the addition of properties.
@jpetrucciani
Copy link
Owner

This works for certain APIs, but will break others like DealsClient and ProductsClient, which actually do use properties= instead of property=. I'm not sure that we should change this default behavior, as that'd break it for anyone currently using that kwarg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MutelS @jpetrucciani