Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6 remove inappropriate for loops #7

Closed
wants to merge 1 commit into from
Closed

#6 remove inappropriate for loops #7

wants to merge 1 commit into from

Conversation

y-aok
Copy link
Contributor

@y-aok y-aok commented Nov 25, 2018

alter list comprehension when making "assignees" update request.

@y-aok
Copy link
Contributor Author

y-aok commented Nov 25, 2018

oops. sorry will re-test this one.

@y-aok y-aok closed this Nov 25, 2018
@y-aok y-aok reopened this Nov 25, 2018
@y-aok
Copy link
Contributor Author

y-aok commented Nov 25, 2018

excuse me, but could you check if this build failure is related to this PR?
I suspect not, since I get same failure when running travis build on my master branch...

@y-aok y-aok closed this Nov 28, 2018
@jpetrucciani jpetrucciani reopened this Nov 29, 2018
@jpetrucciani
Copy link
Owner

Looks like the apiary I was using for the tests had been changed on the ClickUp API page - I've updated that string on master and the tests are all passing again for master.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 39

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 82.447%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyclickup/models/init.py 0 4 0.0%
Totals Coverage Status
Change from base Build 34: -0.9%
Covered Lines: 310
Relevant Lines: 376
💛 - Coveralls

@y-aok
Copy link
Contributor Author

y-aok commented Nov 30, 2018

thank you for update! glad i had not broke your tests...

@y-aok y-aok mentioned this pull request Dec 4, 2018
Closed
@y-aok y-aok closed this Dec 4, 2018
@y-aok y-aok deleted the update_assignees_bug branch December 4, 2018 13:45
@y-aok
Copy link
Contributor Author

y-aok commented Dec 4, 2018

This PR is replaced within #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@y-aok @jpetrucciani @coveralls