Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the Google Drive authorization flow in a separate thread and disable interaction until complete #309

Merged
merged 3 commits into from Jan 17, 2021
Merged

Run the Google Drive authorization flow in a separate thread and disable interaction until complete #309

merged 3 commits into from Jan 17, 2021

Commits on Jan 17, 2021

  1. Run the Google Drive authorization flow in a separate thread 

    Also hides the metadata selector and replaces it with a message when the auth flow is triggered by the menu action. If the auth flow is triggered by a download instead, it will still run on the network thread, but the metadata selector won't be hidden. This is not ideal, but making the download-triggered case the same would be difficult.
    @jpgill86
    jpgill86 committed Jan 17, 2021
    Copy the full SHA
    4363f25 View commit details
    Browse the repository at this point in the history

  2. Suppress OAuth warning about missing token file 

    neurotic already handles this.
    @jpgill86
    jpgill86 committed Jan 17, 2021
    Copy the full SHA
    b7e47c2 View commit details
    Browse the repository at this point in the history

  3. Disable menu bar when launching datasets or running gdrive auth flow 

    The menu bar gets disabled only if the auth flow is triggered by the menu action. It does not get disabled if triggered by a download. This is not ideal, but making the download-triggered case the same would be difficult.
    @jpgill86
    jpgill86 committed Jan 17, 2021
    Copy the full SHA
    d22d3a6 View commit details
    Browse the repository at this point in the history