Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fast loading for Intan files with Neo >= 0.10.0 #324

Merged
merged 2 commits into from Dec 12, 2022
Merged

Fix fast loading for Intan files with Neo >= 0.10.0 #324

merged 2 commits into from Dec 12, 2022

Conversation

jpgill86
Copy link
Owner

@jpgill86 jpgill86 commented Dec 12, 2022 •
edited

Closes #319

Note that the example Intan RHD file added in this PR will not load properly if plots is not set in metadata.

@jpgill86 jpgill86 added the bug Something isn't working label Dec 12, 2022
@jpgill86 jpgill86 added this to the 1.5.1 milestone Dec 12, 2022
@coveralls
Copy link

coveralls commented Dec 12, 2022 •
edited

Coverage Status

Coverage increased (+1.0%) to 59.984% when pulling 14443c5 on fix-intan into a5298b6 on master.

@jpgill86 jpgill86 merged commit cf436b5 into master Dec 12, 2022
@jpgill86 jpgill86 deleted the fix-intan branch December 12, 2022 03:10
@jpgill86 jpgill86 mentioned this pull request Dec 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

Compatibility with Neo 0.10.0 and ephyviewer 1.5.0
2 participants
@jpgill86 @coveralls