Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gettimeofday() function #163

Merged
merged 1 commit into from
Jan 10, 2015
Merged

Conversation

hnw
Copy link
Contributor

@hnw hnw commented Jan 10, 2015

Hi guys,

I'm very interested in this project, so I'd like to implement some PHP functions.
First of all, I choose gettimeofday().
This function is important, because it's used in Zend/bench.php in PHP source code.

Thanks.

dim-s added a commit that referenced this pull request Jan 10, 2015
Implement gettimeofday() function
@dim-s dim-s merged commit 97c57bd into jphp-group:master Jan 10, 2015
@dim-s
Copy link
Member

dim-s commented Jan 10, 2015

Thanks for the function 👍

If you want to implement functions from the zend std library, we will be glad :)

@SerafimArts
Copy link
Contributor

What do u think about rename this function from gettimeofday to getTimeOfDay to match PSR agreement?

@SerafimArts
Copy link
Contributor

Hmmm, this function has no @Signature it is not available from php. Yep? That is, I made a mistake at the expense PSR? Or something I don't know...

@dim-s
Copy link
Member

dim-s commented Jan 10, 2015

@SerafimArts
No, it's not a mistake. You do not need to declare @Signature in a FunctionsContainer, by default all public methods will be wrapped automatically.

@SerafimArts
Copy link
Contributor

Снимаю вопрос, такое именование по PSR касается только методов, для публичных функций ничего не сказано, но по привычке используют underscore, по крайней мере почти во всей php stdlib.

I apologize for the false alarm +)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants