Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SHA256 hashes for key fingerprints #215

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Use SHA256 hashes for key fingerprints #215

merged 2 commits into from
Nov 16, 2020

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Nov 9, 2020

Closes #214

@srueg srueg mentioned this pull request Nov 9, 2020
Closed
@jpillora
Copy link
Owner

jpillora commented Nov 9, 2020

Thanks for the PR though this breaks existing clients using --fingerprint

@jpillora
Copy link
Owner

jpillora commented Nov 9, 2020

Verification should look for hash outputs like this https://play.golang.org/p/7dSkGjdSNO-

  1. 44 chars, ends with =, and then base64 decode, verify sha256
  2. otherwise, hex decode, verify md5

@jpillora
Copy link
Owner

jpillora commented Nov 9, 2020

Also we should update CLI help and docs (mention sha256, undocument md5 hex examples, and support for hash prefixes)

@srueg
Copy link
Contributor Author

srueg commented Nov 9, 2020

Yes, absolutely. Sorry, I wanted to mark the PR as a draft until all the things you mention get implemented.

@jpillora
Copy link
Owner

jpillora commented Nov 9, 2020

No worries 👍

@srueg
Use SHA256 hashes for key fingerprints
7d9a171 
Closes jpillora#214

Signed-off-by: Simon Rüegg <simon@rueggs.ch>
@srueg srueg force-pushed the fingerprint-sha256 branch 3 times, most recently from 02efe35 to 129811e Compare November 10, 2020 07:44
@srueg
Update client to fall-back to MD5 fingerprints
2d6c5cb 
Signed-off-by: Simon Rüegg <simon@rueggs.ch>
@jpillora
Copy link
Owner

PR looks good! Will test soon

@jpillora jpillora merged commit 2d6c5cb into jpillora:master Nov 16, 2020
@jpillora
Copy link
Owner

Thanks :) Merged and released in v1.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use SHA256 Hash for Key Fingerprints
2 participants
@srueg @jpillora