Add support for custom HTTP headers #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be very helpful for me as well. hope you can expedite merging this PR. Thanks |
|
This is great! Was just checking to see if a feature request was in for this. I have an authentication proxy (AWS ALB) in front of a chisel server and need to pass headers to allow the chisel traffic through. |
|
Merged, thanks @AkeemMcLennon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jpillora This pull request adds support for custom http headers in the client request (beyond host). This can be useful for getting behind reverse proxies that require authentication headers for processing the request.
I also refactored the
--hostnameparameter to use the custom header logic and added a few unit tests for the new functionality.The new tests can be run through
go test ./...