Pr response format #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 16, 2014 15:03
It appears from a raw log of entry object that the property name is 'gs:cell'
Google Spreadsheet services may return an empty object if when asked for JSON format (alt=json in url) Try to parse JSON output in request method, and then try to parse it as XML if the JSON attempt failed Should solve jpillora#29
|
merged and published 0.2.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid having to handle JSON or XML response format according to document version, I added a xml2json conversion in request method, called only if JSON parsing fails.
This solved for me all problems I see in #29 discussion, although this may not be the best workaround...