-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows watchParent() fix #42
Conversation
Thanks for the PR! Looks like this supports linux and windows, but misses the other operating systems. See |
Can probably be |
Build tags: windows
For other oses than windows
Thanks. I forgot other oses as I only build linux and windows binaries. |
Merged! Thanks :) |
Hey @chicknsoup I just added auto testing and the windows build is failing. See https://github.com/jpillora/overseer/actions/runs/65595163 I don't have a windows machine, can you please check this? |
I pushed a fix but needs testing |
Slave process watches its parent by sending Signal(0), but as stated in
os/exec.go
sending Interrupt on Windows is not implemented. This cause prog exits with status code 1 error.This fix uses
gopsutil
to check for process existence on Windows.