Skip to content

Commit

Permalink
mlxsw: core_linecards: Probe devices for provisioned line card and at…
Browse files Browse the repository at this point in the history 
…tach them

In case the line card is provisioned, go over all possible existing
devices (gearboxes) on it and attach them, so devlink core is aware of
them. In case the device can be flashed, register mlxsw flash component.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
  • Loading branch information
Jiri Pirko committed Jan 28, 2022
1 parent 5038180 commit 73018c5
Show file tree
Hide file tree
Showing 2 changed files with 106 additions and 9 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/mellanox/mlxsw/core.h
View file
Expand Up @@ -589,6 +589,7 @@ struct mlxsw_linecard {
active:1;
u16 hw_revision;
u16 ini_version;
struct list_head device_list;
};

struct mlxsw_linecard_types_info;
Expand Down
114 changes: 105 additions & 9 deletions drivers/net/ethernet/mellanox/mlxsw/core_linecards.c
View file
Expand Up @@ -65,20 +65,109 @@ static const char *mlxsw_linecard_type_name(struct mlxsw_linecard *linecard)
return linecard->name;
}

static void mlxsw_linecard_provision_fail(struct mlxsw_linecard *linecard)
struct mlxsw_linecard_device {
struct list_head list;
u8 index;
struct mlxsw_linecard *linecard;
struct devlink_linecard_device *devlink_device;
};

static int mlxsw_linecard_device_attach(struct mlxsw_core *mlxsw_core,
struct mlxsw_linecard *linecard,
u8 device_index, bool flash_owner)
{
struct mlxsw_linecard_device *device;
int err;

device = kzalloc(sizeof(*device), GFP_KERNEL);
if (!device)
return -ENOMEM;
device->index = device_index;
device->linecard = linecard;

device->devlink_device = devlink_linecard_device_create(linecard->devlink_linecard,
device_index,
NULL, NULL);
if (IS_ERR(device->devlink_device)) {
err = PTR_ERR(device->devlink_device);
goto err_devlink_linecard_device_attach;
}

list_add_tail(&device->list, &linecard->device_list);
return 0;

err_devlink_linecard_device_attach:
kfree(device);
return err;
}

static void mlxsw_linecard_device_detach(struct mlxsw_core *mlxsw_core,
struct mlxsw_linecard *linecard,
struct mlxsw_linecard_device *device)
{
list_del(&device->list);
devlink_linecard_device_destroy(linecard->devlink_linecard,
device->devlink_device);
kfree(device);
}

static int mlxsw_linecard_devices_attach(struct mlxsw_core *mlxsw_core,
struct mlxsw_linecard *linecard)
{
char mddq_pl[MLXSW_REG_MDDQ_LEN];
bool flash_owner;
bool data_valid;
u8 device_index;
u8 msg_seq = 0;
int err;

do {
mlxsw_reg_mddq_device_info_pack(mddq_pl, linecard->slot_index,
msg_seq);
err = mlxsw_reg_query(mlxsw_core, MLXSW_REG(mddq), mddq_pl);
if (err)
return err;
mlxsw_reg_mddq_device_info_unpack(mddq_pl, &msg_seq,
&data_valid, &flash_owner,
&device_index);
if (!data_valid)
break;
err = mlxsw_linecard_device_attach(mlxsw_core, linecard,
device_index, flash_owner);
if (err)
return err;
} while (msg_seq);

return 0;
}

static void mlxsw_linecard_devices_detach(struct mlxsw_core *mlxsw_core,
struct mlxsw_linecard *linecard)
{
struct mlxsw_linecard_device *device, *tmp;

list_for_each_entry_safe(device, tmp, &linecard->device_list, list)
mlxsw_linecard_device_detach(mlxsw_core, linecard, device);
}

static void mlxsw_linecard_provision_fail(struct mlxsw_core *mlxsw_core,
struct mlxsw_linecard *linecard)
{
linecard->provisioned = false;
linecard->ready = false;
linecard->active = false;
mlxsw_linecard_devices_detach(mlxsw_core, linecard);
devlink_linecard_provision_fail(linecard->devlink_linecard);
}

static int
mlxsw_linecard_provision_set(struct mlxsw_linecards *linecards,
mlxsw_linecard_provision_set(struct mlxsw_core *mlxsw_core,
struct mlxsw_linecards *linecards,
struct mlxsw_linecard *linecard, u8 card_type,
u16 hw_revision, u16 ini_version)
{
const char *type = mlxsw_linecard_types_lookup(linecards, card_type);
int err;

if (!type) {
/* It is possible for a line card to be provisioned before
Expand All @@ -89,10 +178,13 @@ mlxsw_linecard_provision_set(struct mlxsw_linecards *linecards,
*/
type = mlxsw_linecard_type_name(linecard);
if (IS_ERR(type)) {
mlxsw_linecard_provision_fail(linecard);
mlxsw_linecard_provision_fail(mlxsw_core, linecard);
return PTR_ERR(type);
}
}
err = mlxsw_linecard_devices_attach(mlxsw_core, linecard);
if (err)
return err;
linecard->provisioned = true;
linecard->hw_revision = hw_revision;
linecard->ini_version = ini_version;
Expand All @@ -103,6 +195,8 @@ mlxsw_linecard_provision_set(struct mlxsw_linecards *linecards,
static void mlxsw_linecard_provision_clear(struct mlxsw_linecard *linecard)
{
linecard->provisioned = false;
mlxsw_linecard_devices_detach(linecard->linecards->mlxsw_core,
linecard);
devlink_linecard_provision_clear(linecard->devlink_linecard);
}

Expand Down Expand Up @@ -180,9 +274,9 @@ static int mlxsw_linecard_status_process(struct mlxsw_core *mlxsw_core,
cancel_delayed_work_sync(&linecard->status_event_to_dw);

if (provisioned && linecard->provisioned != provisioned) {
err = mlxsw_linecard_provision_set(linecards, linecard,
card_type, hw_revision,
ini_version);
err = mlxsw_linecard_provision_set(mlxsw_core, linecards,
linecard, card_type,
hw_revision, ini_version);
if (err)
goto out;
}
Expand Down Expand Up @@ -381,7 +475,7 @@ static void mlxsw_linecard_bct_process(struct mlxsw_core *mlxsw_core,

fix_fsm_out:
mlxsw_linecard_fix_fsm_state(linecard, fsm_state);
mlxsw_linecard_provision_fail(linecard);
mlxsw_linecard_provision_fail(mlxsw_core, linecard);
}

static int
Expand Down Expand Up @@ -525,7 +619,7 @@ static int mlxsw_linecard_provision(struct devlink_linecard *devlink_linecard,
goto out;

err_out:
mlxsw_linecard_provision_fail(linecard);
mlxsw_linecard_provision_fail(mlxsw_core, linecard);
out:
mutex_unlock(&linecard->lock);
return err;
Expand Down Expand Up @@ -560,7 +654,7 @@ static int mlxsw_linecard_unprovision(struct devlink_linecard *devlink_linecard,
goto out;

err_out:
mlxsw_linecard_provision_fail(linecard);
mlxsw_linecard_provision_fail(mlxsw_core, linecard);
out:
mutex_unlock(&linecard->lock);
return err;
Expand Down Expand Up @@ -730,6 +824,7 @@ static int mlxsw_linecard_init(struct mlxsw_core *mlxsw_core,
linecard->slot_index = slot_index;
linecard->linecards = linecards;
mutex_init(&linecard->lock);
INIT_LIST_HEAD(&linecard->device_list);

devlink_linecard = devlink_linecard_create(priv_to_devlink(mlxsw_core),
slot_index, &mlxsw_linecard_ops,
Expand Down Expand Up @@ -781,6 +876,7 @@ static void mlxsw_linecard_fini(struct mlxsw_core *mlxsw_core,
mlxsw_core_flush_owq();
if (linecard->active)
mlxsw_linecard_active_clear(linecard);
mlxsw_linecard_devices_detach(mlxsw_core, linecard);
devlink_linecard_destroy(linecard->devlink_linecard);
mutex_destroy(&linecard->lock);
}
Expand Down

0 comments on commit 73018c5

Please sign in to comment.