Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding bug #115

Closed
sebinside opened this issue May 31, 2021 · 3 comments
Closed

Fix encoding bug #115

sebinside opened this issue May 31, 2021 · 3 comments
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change

Comments

@sebinside
Copy link
Member

There is still a bug that breaks Jplag if, e.g., german umlauts or other non-ASCII characters are used.

Releated to #7 and #77.

@sebinside sebinside added bug Issue/PR that involves a bug major Major issue/feature/contribution/change labels May 31, 2021
@tsaglam
Copy link
Member

tsaglam commented Sep 15, 2021

I fixed a few encoding issues by enforcing UTF-8 (#177 and #185), but these PRs concern the core and the Java 9+ frontend. Other language frontends might still use the system default charset when reading in files, thus leading to encoding issues.

@tsaglam
Copy link
Member

tsaglam commented Oct 15, 2021

Also, some language frontends use a grammar-based parser that explicitly limits identifiers to e.g. [a-z, A-Z, 0-9].

@tsaglam tsaglam added minor Minor issue/feature/contribution/change and removed major Major issue/feature/contribution/change labels Dec 14, 2021
@tsaglam
Copy link
Member

tsaglam commented Feb 9, 2023

Closed, as this is also discussed in #746. This issue will be linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Development

No branches or pull requests

2 participants