Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file encoding issue #177

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Fix file encoding issue #177

merged 2 commits into from
Sep 7, 2021

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Aug 16, 2021

When using volume testing, I encountered an encoding issue when reading the CSV file (IOException).
This PR enforces consistent encoding in JPlag. We might even offer different file encoding based on the JPlagOptions.
Additionally, I removed unused verbosity options.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Aug 16, 2021
@tsaglam tsaglam marked this pull request as ready for review August 16, 2021 14:49
@sebinside sebinside added this to the v3.0.0 milestone Aug 26, 2021
@tsaglam tsaglam merged commit 39290c6 into master Sep 7, 2021
@tsaglam tsaglam deleted the encoding branch September 8, 2021 10:06
@tsaglam tsaglam mentioned this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants