fixed class for PEP and changed constants to class variables #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplattel
added a commit
that referenced
this pull request
Feb 17, 2014
fixed class for PEP and changed constants to class variables
| API_URL = 'https://api.moves-app.com/oauth/v1/' | ||
| def __init__(self, client_id, client_secret, redirect_url, \ | ||
| api_url = 'https://api.moves-app.com/oauth/v1/'): | ||
| self.client_id = client_id # Client ID, get this by creating an app |
There was a problem hiding this comment.
Should these not be indented another level?
There was a problem hiding this comment.
Yeah, line 8 should be intended. Sorry, haven't time for this project any more now :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use your class in my next project and I'd appreciate it if you could use my changes in your original class.