Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically destroy removed instances #150

Merged
merged 1 commit into from
Nov 24, 2014
Merged

Automatically destroy removed instances #150

merged 1 commit into from
Nov 24, 2014

Commits on Mar 25, 2013

  1. Automatically destroy removed instances 

    With multiple instances of jplayer, if one got removed from the dom without being destroyed, the others would cause a javascript error on play. This was caused by keeping a list of instances ($.jPlayer.prototype.instances) that would get out of sync with the page. With this patch, jPlayer clears the list of any nonexistent instances before iterating over the list.

The error was triggered from pauseOthers() and $.jPlayer.pause().
    @sterlinghirsh
    sterlinghirsh committed Mar 25, 2013
    Configuration menu
    Copy the full SHA
    c30b049 View commit details
    Browse the repository at this point in the history