Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename exception classes #83

Closed
vruusmann opened this issue Nov 15, 2017 · 1 comment
Closed

Rename exception classes #83

vruusmann opened this issue Nov 15, 2017 · 1 comment

Comments

@vruusmann
Copy link
Member

The following two exceptions are throws to indicate a structural problem with a PMML document:

  • org.jpmml.evaluator.InvalidFeatureException
  • org.jpmml.evaluator.UnsupportedFeatureException

Unfortunately, the use of a substring "feature" is confusing, because it might lead end users to believe that there is something wrong with input data (as "feature" is commonly used to refer to input fields).

Therefore, the substring "feature" could be replaced with a substring "markup":

  • org.jpmml.evaluator.InvalidMarkupException
  • org.jpmml.evaluator.UnsupportedMarkupException
@vruusmann
Copy link
Member Author

This rename should be implemented in the 1.4.X development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant