Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

author.uri and author.email should be optional in atom #115

Closed
wants to merge 2 commits into from
Closed

author.uri and author.email should be optional in atom #115

wants to merge 2 commits into from

Conversation

endquote
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 93.088% when pulling 69faaee on endquote:author into 2773651 on jpmonette:master.

@jpmonette
Copy link
Owner

@endquote Can you provide literature for JSON and Atom feed please?

@endquote
Copy link
Contributor Author

endquote commented Mar 19, 2020 •
edited

Atom:
"<author> and <contributor> describe a person, corporation, or similar entity. It has one required element, name, and two optional elements: uri, email."
https://validator.w3.org/feed/docs/atom.html#person

JSON:
"The author object has several members. These are all optional..."
https://jsonfeed.org/version/1

@decebal decebal mentioned this pull request Jun 5, 2020
Merged
jpmonette pushed a commit that referenced this pull request Jul 5, 2020
@endquote @decebal
author.uri and author.email should be optional in atom #115 (#124)
15c6ccc 
* email/uri are optional for atom authors

* test: add coverage for optional cases

* test: update syntax

Co-authored-by: Josh Santangelo <josh@endquote.com>
Co-authored-by: Decebal Dobrica <decebal.dobrica@tellimer.com>
@jpmonette
Copy link
Owner

Added here - #124 (review)

@jpmonette jpmonette closed this Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@endquote @coveralls @jpmonette